docs: use crypto.randomBytes in diskStorage README example#1436
Open
Hashim1999164 wants to merge 1 commit into
Open
docs: use crypto.randomBytes in diskStorage README example#1436Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
Replace Math.random() in the custom filename example with crypto.randomBytes, matching multer's secure default filename generator. Fixes expressjs#1386
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
diskStoragecustomfilenameexample to usecrypto.randomBytesinstead ofMath.random().storage/disk.js.Fixes #1386
Test plan
crypto.randomBytesinstorage/disk.js