-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: don't crop the OpenJS trademark on desktop #2183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+5
−7
Closed
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
05f2653
fix: don't crop OpenJS trademark on desktop
notsecret808 2c35136
chore: revert style.css to crlf
notsecret808 9740200
Merge branch 'gh-pages' into gh-pages
notsecret808 6798e10
style: make icon responsive, remove unuses cursor
notsecret808 4cd9d0d
Merge branch 'gh-pages' into gh-pages
notsecret808 4c76f4f
fix foundation logo clickable area on small screens
ShubhamOulkar cb7829f
Merge branch 'gh-pages' into gh-pages
ShubhamOulkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -782,7 +782,7 @@ footer { | |||
|
|
||||
| /* icons */ | ||||
| a.openjs-logo { | ||||
| display: inline-block; | ||||
| display: flex; | ||||
| width: 125px; | ||||
| height: 39px; | ||||
| cursor: pointer; | ||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Anchors already have pointer cursor by default. |
||||
|
|
||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only child component so it is not ideal here.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Now it's working as exprected. Sorry, I think that the problem was on my side during the building of the app.