docs: add RFC for shared logging facade (@expressjs/log)#509
Open
bjohansebas wants to merge 1 commit into
Open
docs: add RFC for shared logging facade (@expressjs/log)#509bjohansebas wants to merge 1 commit into
@expressjs/log)#509bjohansebas wants to merge 1 commit into
Conversation
bjohansebas
added
top priority
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, this is my main idea for keeping logging implementation-agnostic: #459.
The core idea is that it doesn't depend on any logging library. By default, it has no logger configured. If you call
.setConsumer(), you provide the logging implementation to use.If
NODE_DEBUG=expressis set (see the RFC for the reasoning behind this), it will instead write tostderrusing the currentdebug-style output as a migration path.The goal is to avoid taking a dependency on any specific logger, at least initially. It also makes the package platform-agnostic, so it could work in browsers as well if needed—for example, if packages like
cookieever wanted to use it in the future.I'd like to implement this package once we've finalized the design