Repository navigation
fix: State that updateCallState acts as the message's exoId EXO-91103 - #428
Merged
rdenarie merged 1 commit intoOct 23, 2026
Merged
Conversation
The Javadoc of updateCallState said a participant state applies to the user of the Cometd session; it applies to the exoId the client's message names, which nothing checks against the session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
The Javadoc of
CometdWebConferencingService.updateCallStatesaid a participant state "always applies to the user of the Cometd session, never to a user named by the client". A reader of that comment concludes that the join, leave and decline sent through the CometDupdatecommand cannot act for another user.Cause
rcCallsreadscurrentUserIdfrom the message's ownexoIdargument. The CometD session is only used in a debug log.updateCallStatehands that id tojoinCall,leaveCallanddeclineCall, and nothing checks it against the session's user.Fix
The Javadoc and its
@paramnow say what the code does: the state applies to the message'sexoId, which nothing checks against the session. The comment changes and nothing else. The gap itself is a separate security task, EXO-92019.Knowledge: Meeds-io/eng-standards#678