Repository navigation
feat: Show a single planned call people already joined as in progress in the video list EXO-91106 - #425
Merged
rdenarie merged 1 commit intoOct 21, 2026
Conversation
… in the video list EXO-91106 A started call of a single event makes it live whatever its date; an occurrence of a series still holds its call only once it has begun or starts within 15 minutes. A live meeting joined ahead of its slot shows no elapsed time before its start.
Member
Author
Self-review close-out — EXO-91106 @ 57d358c
Final reviewer round at 57d358c: clean, nothing to fix. Verified conform: Classification: N2, advisory on this developer FB (shared drawer, no REST/DAO/schema/ACL surface), computed at 57d358c; the eXip is classified at its |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A call people already joined, attached to a single planned event, stayed listed as upcoming in the video list drawer until 15 minutes before the event, hiding a running call from its invitees (EXO-91106, eXIP 7.3.0.41 US06).
How
VisioMerge.js:normalizeEventmarks an entryrecurrentwhen the agenda payload carries an occurrence, a parent or a recurrence (computed and exceptional occurrences of a series).canHoldCallno longer applies theJOIN_AHEAD_MSwindow to a single event: its started call makes it live whatever its date. An occurrence of a series keeps the 15-minute rule, so a later occurrence never shows the call of one the user declined, which the drawer does not read.VisioCard.vue: a live scheduled meeting shows no elapsed time before its slot's start. Ad hoc calls and rooms, whose start is the server's, are not compared with the browser's clock.Known limits
Verification
A throwaway harness (not committed, per the frontend norm) over
normalizeEventandbuildEntrieson raw agenda payloads, with the card's progress rule transcribed fromVisioCard.vue, run ongit archive 57d358c5ofVisioDrawer:node simple.mjs js/VisioMerge.js→ 12 PASS / 0 FAIL.The base code fails the two single-event-ahead scenarios; marking
recurrentfrom the occurrence alone fails the parent-id-only and recurrence-only ones.mvn -pl webapp -am verify -Pcoverage -Prun-itsat 57d358c: Tests run: 171, Failures: 0, Errors: 0, Skipped: 0, BUILD SUCCESS.eslinton both files: 0 errors.Knowledge: pending — EXO-91195
Classification (advisory on this developer FB, computed on
git diff origin/feature/security-fix...HEADat 57d358c): N2 — no REST/DAO/schema/ACL surface touched, behaviour change in the drawer shared by every call provider. The eXip is classified on its full diff at itsfeature/mipsintegration PR.