fix: replace JS window.open with links - EXO-89155 - #2072
Merged
Conversation
ahamdi
enabled auto-merge (squash)
September 4, 2026 15:00
exo-swf
force-pushed
the
feature/maintenance
branch
from
September 4, 2026 23:23
c67d1e7 to
cc87970
Compare
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ahamdi
force-pushed
the
fix/EXO-89155
branch
from
September 7, 2026 08:36
060ada8 to
470792b
Compare
AzmiTouil
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
Prior to this change, opening a document for editing/viewing (and a handful of other document actions — WebDAV drive links, folder navigation, newly-created attachments) called window.open(url, target) directly across the Documents webapp. Direct window.open calls bypass native browser link semantics (no hover preview, no right-click "open in new tab", no middle-click support) and, in one path (EditMenuAction.vue / OpenReadOnlyMenuAction.vue), were reported to pop the editor in a separate browser window instead of a tab depending on browser settings.
How does it address the issue?
This change replaces every window.open call in documents-webapp with real -based navigation:
No functional/URL-building logic changed — only how the resulting URL is navigated to.
Knowledge: none — mechanical window.open → conversion using the addon's existing DocumentsUtils helper pattern, no new architecture or extension point introduced.