Conversation
vsellier
left a comment
vsellier
left a comment
There was a problem hiding this comment.
Invalidated as it needs more tests.
Their is also no apache configuration to expose the container. IMO at least a http / https and ldap protected / unprotected version should be need
| env_var PRODUCT_BRANCH `expr "${PRODUCT_VERSION}" : '\([0-9]*\.[0-9]*\).*'`".x" | ||
| env_var PRODUCT_MAJOR_BRANCH `expr "${PRODUCT_VERSION}" : '\([0-9]*\).*'`".x" | ||
| configurable_env_var "INSTANCE_ID" "" | ||
| if [[ -v PRODUCT_VERSION ]]; then |
There was a problem hiding this comment.
The -v option is not available on macos. Is it not possible to use a classical test with -z or -n ?
Why not using a test on PRODUCT_NAME == docker ?
| fi | ||
| # docker image should have INSTANCE_KEY | ||
| if [ -n "${DEPLOYMENT_DOCKER_IMAGE}" ]; then | ||
| env_var "INSTANCE_KEY" "docker-${DEPLOYMENT_DOCKER_IMAGE}-${DOCKER_IMAGE_VERSION}" |
There was a problem hiding this comment.
You should not lose the INSTANCE_ID parameter if we want to be able to deploy several time the same image
| # Mandatory env vars. They need to be defined before launching the script | ||
| validate_env_var "PRODUCT_NAME" | ||
| validate_env_var "PRODUCT_VERSION" | ||
| configurable_env_var "PRODUCT_VERSION" "" |
There was a problem hiding this comment.
The validate should be moved on the previous test to ensure it's defined
| # Hack | ||
| do_configure_chat | ||
|
|
||
| fi |
There was a problem hiding this comment.
The indentation looks weird
| fi | ||
| fi | ||
| # docker image should have INSTANCE_KEY | ||
| if [ -n "${DEPLOYMENT_DOCKER_IMAGE}" ]; then |
There was a problem hiding this comment.
In a plf deployment this variable is not set, the test will failed will failed
7e2ade5 to
ae38ca8
Compare
2 participants
No description provided.