Draft
Conversation
rltakashige
force-pushed
the
leo/add-gemma-4
branch
from
04f0101 to
241cca9
Compare
rltakashige
force-pushed
the
leo/add-gemma-4-parallelism
branch
from
fc457e9 to
f1c9067
Compare
Evanev7
force-pushed
the
leo/add-gemma-4
branch
from
89694da to
f6e9bbe
Compare
Contributor
|
I fixed the issue mentioned here: #1873. Attached the patch file (that can be directly applied onto this branch). |
|
I just tested the .patch file. Fixed the issue for me. It's now running with RDMA/Tensor parallelism on two M4 Pro Mac's |
Contributor
|
@RWL-Dittrich Thanks for checking! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
Why It Works
Test Plan
Manual Testing
Automated Testing