Skip to content

rational-numbers passes with latest vlang #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kahgoh merged 1 commit into from
Apr 6, 2026
Merged

rational-numbers passes with latest vlang #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions exercises/practice/rational-numbers/.meta/example.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ pub fn Rational.new(numerator i64, denominator i64) Rational {

cmn_div := gcd(numerator, denominator)

sign := if signi(numerator) == -1 || signi(denominator) == -1 {
sign := if numerator < 0 || denominator < 0 {
-1
} else {
1
Expand Down Expand Up @@ -53,15 +53,12 @@ pub fn (r Rational) exprational(n i64) Rational {
n_pos := math.abs(n)
result := Rational.new(powi(r.numerator, n_pos), powi(r.denominator, n_pos))

return match signi(n) {
1 { result }
else { result.invert() }
}
return if n > 0 { result } else { result.invert() }
}

// n^r
pub fn (r Rational) expreal(n i64) f64 {
return pow(n, f64(r.numerator) / f64(r.denominator))
return pow(f64(n), f64(r.numerator) / f64(r.denominator))
}

pub fn (r Rational) mul(other Rational) Rational {
Expand Down
Loading