Skip to content

Sync connect tests#290

Merged
kahgoh merged 1 commit intoexercism:mainfrom
keiravillekode:sync-connect
Apr 7, 2026
Merged

Sync connect tests#290
kahgoh merged 1 commit intoexercism:mainfrom
keiravillekode:sync-connect

Conversation

@keiravillekode
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@kahgoh
Copy link
Copy Markdown
Member

kahgoh commented Apr 6, 2026

Looking into the CI failures on this one, I think the errors has nothing to do with the changes here.

The only way I could reproduce the CI error using bin/test was to update V lang to the latest on their main branch.

If I download and use the latest release of V (0.5.1), bin/test works completely fine. However, if I run v up it seems to use Git to update to the latest version of V on their main branch. If I then run bin/test I then get similar errors as the CI (there are errors with both Grade School and Zebra Puzzle). I am thinking this being a problem with V itself since it isn't using a "release" version. Output from the setup Vlang action also suggests it was on 737163c, which isn't tagged as a release version. @keiravillekode, what do you think about tying the action to specific version of V?

@keiravillekode
Copy link
Copy Markdown
Contributor Author

Sure.

There remains the issue that students might download the next V release and experience the bug, so we should also report it.

@kahgoh
Copy link
Copy Markdown
Member

kahgoh commented Apr 7, 2026

Nevermind, I think the errors were caused by trying to add items to lists that were not initialized properly. I have raised a PR #293 to fix. There are probably still issues to report to the V lang project, but I'll do that later.

@kahgoh kahgoh merged commit 218e961 into exercism:main Apr 7, 2026
1 of 7 checks passed
@keiravillekode keiravillekode deleted the sync-connect branch April 7, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants