Merged
Conversation
|
Hello 👋 Thanks for your PR. This repo does not currently have dedicated maintainers. Our guardians team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed. If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track. Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum. (cc @exercism/guardians) |
glennj
approved these changes
Mar 23, 2026
glennj
approved these changes
Mar 25, 2026
glennj
left a comment
glennj
left a comment
There was a problem hiding this comment.
Looks OK. I admit to just skimming test-runner.bxs
IsaacG
approved these changes
Mar 27, 2026
Member
IsaacG
left a comment
IsaacG
left a comment
There was a problem hiding this comment.
No comment on the cfml test runner as I don't speak that language.
kotp
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shaves off about 200 MB off the existing v1 test runner (528 MB to 347 MB). Most of the image isn't CFML or BoxLang but the JDK so in a second pass, we might be able to tinker with the base Docker image.
This PR is a bit noisy since I rebuilt the tests and fewer files are needed. Since this setup runs CFML code natively, I don't believe there are breaking changes. The CFML track bundles a test runner for the students working locally. That'll be kept for students choosing to use CommandBox, but I'll provide an updated BoxLang-compatible runner as well. That'll be significantly less complicated than the test-runner.bxs used here.