Skip to content

344 ewoks events sqlite3 bugs - #345

Merged
woutdenolf merged 7 commits into
mainfrom
344-ewoks-events-sqlite3-bugs
Aug 2, 2026
Merged

344 ewoks events sqlite3 bugs#345
woutdenolf merged 7 commits into
mainfrom
344-ewoks-events-sqlite3-bugs

Conversation

@woutdenolf

Copy link
Copy Markdown
Member

@woutdenolf woutdenolf self-assigned this Jul 14, 2026
@woutdenolf woutdenolf linked an issue Jul 14, 2026 that may be closed by this pull request
@woutdenolf
woutdenolf requested a review from a team July 14, 2026 14:28

@payno payno left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lokos good.
Side note: ewoksutils >=1.10.0 was already set.

@woutdenolf

Copy link
Copy Markdown
Member Author

This will require bumping

  • ewoksutils>=2.0.0rc1
  • ewokscore>=5.1.0rc1

@woutdenolf
woutdenolf force-pushed the 344-ewoks-events-sqlite3-bugs branch from a6c5872 to 0ac0325 Compare July 31, 2026 15:30
@codecov

codecov Bot commented Aug 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.85366% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ewoksjob/events/handlers/redis.py 0.00% 8 Missing ⚠️
src/ewoksjob/events/readers/sqlite3.py 76.92% 3 Missing ⚠️
src/ewoksjob/events/readers/redis.py 33.33% 2 Missing ⚠️
src/ewoksjob/events/readers/base.py 94.11% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@woutdenolf

woutdenolf commented Aug 2, 2026

Copy link
Copy Markdown
Member Author

Sqlite3 was broken for gevent: is not cooperative and retry needs to be done in the python level.

ewoks-kit/ewoksutils#92

This will require bumping

  • ewoksutils>=2.0.0rc2
  • ewokscore>=5.1.0rc2

@woutdenolf
woutdenolf force-pushed the 344-ewoks-events-sqlite3-bugs branch from 4997c3c to 617818f Compare August 2, 2026 13:47
@woutdenolf
woutdenolf merged commit 7da9232 into main Aug 2, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ewoks events: sqlite3 bugs

2 participants