Support rendering a subset of CommonMark in the chat#778
Support rendering a subset of CommonMark in the chat#778robinlinden wants to merge 1 commit intoevilcorpltd:masterfrom
Conversation
7cf8df5 to
201d010
Compare
This is a very simple (and non-compliant!) implementation and will be replaced by something more proper later. Overlapping styles aren't handled at all right now.
201d010 to
e711a82
Compare
|
Back when prototyping this (this PR is not complete at all, just for a few testers to check it out and see what they though), I looked at different implementations but didn't find one I was 100% happy with, and since I only want a tiny subset of markdown, I figured the easiest thing would be to hack together a small parser (i.e. the regex is not intended to stay). The things I want:
This is apparently half a year old now, so if there are any small-ish markdown-implementations that check my boxes, that would be nice. :P I did look at Markwon, but I don't recall why I didn't like it, so maybe it's a fine option. |
|
From what I understood you can control pretty much everything in Markwon. Why not remove those characters? Maybe it's possible to remove them like the default behavior but copying them when copying the message. |
The types implemented in this PR are bold, italic, and monospace text.
Resolves #238