Ask for mic permission from callfFagment#1331
Open
TrueWatcher wants to merge 4 commits intoevilcorpltd:masterfrom
Open
Ask for mic permission from callfFagment#1331TrueWatcher wants to merge 4 commits intoevilcorpltd:masterfrom
TrueWatcher wants to merge 4 commits intoevilcorpltd:masterfrom
Conversation
This was referenced Dec 5, 2025
Contributor
Author
|
By the way, what will be result of calling CallManager.startSendingAudio() when the thing is already sending frames ?
I added the check in this commit, but I'm not sure, My Kotlin is not good enough.. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } else { | ||
| Toast.makeText(requireContext(), getString(R.string.call_mic_permission_needed), Toast.LENGTH_LONG).show() | ||
| Log.d(TAG, "Got no permission") | ||
| // Toast.makeText(requireContext(), getString(R.string.call_mic_permission_needed), Toast.LENGTH_LONG).show() |
Check warning
Code scanning / detekt
Line detected, which is longer than the defined maximum line length in the code style. Warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the app's fresh run,
when the user gets to the call screen, they are asked for the microphone permission.
With the permission granted or denied (and remembered by OS), it's not asked for again.
If the permission has been granted, the mic is on by default, but may be muted with the microphone control button.
If the permission has been denied, the mic is off. On pressing its control, a warning is displayed. This kind of users is expected to know what they do, and to be able to turn the permission on via System Settings - Apps.
This PR is untended to work with #1330
Together they close issues #1316 and #1315