Fix returndatacopy_after_failing_delegatecallFiller#1420
Fix returndatacopy_after_failing_delegatecallFiller#14200xVolosnikov wants to merge 1 commit intoethereum:developfrom
Conversation
|
rebase |
|
or can just plain convert it into pyspecs |
| "currentTimestamp" : "0x03e8" | ||
| }, | ||
| "pre" : { | ||
| "0x0f572e5295c57f15886f9b263e2f6d2d6c7b5ec6" : { |
There was a problem hiding this comment.
What was this account for and why have you removed it?
There was a problem hiding this comment.
the test apparently had a typo. and was calling this empty account instead of account with the actual code
There was a problem hiding this comment.
I understand the main bug, but not sure why this account was in the test.
There was a problem hiding this comment.
copy paste error. the test was not doing anything
|
This also affects legacy tests. |
| "pre" : { | ||
| "0x0f572e5295c57f15886f9b263e2f6d2d6c7b5ec6" : { | ||
| "balance": "0x100000", | ||
| "code": "", |
There was a problem hiding this comment.
so I think here would have been the call to 100...1 which fails. and then sstore[1] = 1 to indicate that the test worked
|
|
3 participants
Fixes #1417