Add lock_retries join option (default: 1) - #65
Merged
Merged
Conversation
chrzaszcz
force-pushed
the
lock-retries
branch
4 times, most recently
from
August 6, 2026 13:28
5f24b32 to
54a0445
Compare
The CETS join process takes a global lock on all cluster nodes. When multiple nodes attempt to join simultaneously, acquiring the lock frequently fails. As a result, global:trans returns aborted, and join_loop retries immediately, creating a long living retry loop Original PR: #64 I made the tests less verbose and more configurable. I also increased the likelihood of failure by increasing the number of nodes and decreasing the total test timeout. Now it is reliably failing before the fix, and succeeding after it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
+ Coverage 98.46% 98.58% +0.11%
==========================================
Files 11 11
Lines 846 846
==========================================
+ Hits 833 834 +1
+ Misses 13 12 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CETS join process takes a global lock on all cluster nodes. When multiple nodes attempt to join simultaneously, acquiring the lock frequently fails.
As a result,
global:transreturns aborted, andjoin_loopretries immediately, creating a long living retry loopOriginal PR: #64
I made the tests less verbose and more configurable. I also increased the likelihood of failure by increasing the number of nodes and decreasing the total test timeout.
Manual checks on my local machine with
{repeat_until_any_fail, 10}:CI is less stable though, and it failed once after the fix. Rerun was successful.
I think we could address the stability of tests in a separate PR, as other (unrelated) tests are flaky on my machine as well.