Introducing setting scope (local/global) - #197
Merged
Merged
Conversation
DenysGonchar
force-pushed
the
adding-scope-for-amoc-settings
branch
3 times, most recently
from
April 27, 2026 08:47
b47b493 to
06bb385
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 76.81% 77.01% +0.20%
==========================================
Files 32 32
Lines 1169 1201 +32
==========================================
+ Hits 898 925 +27
- Misses 271 276 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DenysGonchar
force-pushed
the
adding-scope-for-amoc-settings
branch
12 times, most recently
from
April 29, 2026 10:08
ed5d3f2 to
83eb6c1
Compare
DenysGonchar
marked this pull request as ready for review
April 29, 2026 11:33
kamilwaz
reviewed
Apr 29, 2026
DenysGonchar
force-pushed
the
adding-scope-for-amoc-settings
branch
from
April 29, 2026 13:21
83eb6c1 to
95bd45f
Compare
kamilwaz
approved these changes
May 4, 2026
NelsonVides
reviewed
May 4, 2026
DenysGonchar
force-pushed
the
adding-scope-for-amoc-settings
branch
from
May 4, 2026 12:11
95bd45f to
890a7c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added scope for configuration parameters.
• global parameters can be set on master node only, also they are automatically propagated to the slave nodes.
• local paramteres can be set per node.
also fixed amoc_throttle:stop() for throttles with gradually changing rates