Conversation
- TeamID displays as TEamID instead of name or logo - In the SMJHL/IIHF/WJC there are moments where 2 users occupy the same ID. DB cleanup or more code massaging. DB cleanup would be preffered
luketd
force-pushed
the
feat/portal-integration
branch
from
April 28, 2025 22:43
f62aea8 to
c7a1ca6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better Portal Integration
- Getting the portalID and adding a link in the playerID
- Issue I need to work through for players who occupy the same playerID
- Getting achievementInfo for players
- Need to get team abbreviation. Might be best to just put it in the api for the portal
Need better design maybe