Skip to content

refactor(contact_player.py): part1: basic refactoring, move functionality to main() function - #20

Merged
gh0st42 merged 1 commit into
mainfrom
refactor/contact-player-part1
Aug 24, 2026
Merged

refactor(contact_player.py): part1: basic refactoring, move functionality to main() function#20
gh0st42 merged 1 commit into
mainfrom
refactor/contact-player-part1

Conversation

@axodentally

Copy link
Copy Markdown
Collaborator

Move the main script logic into a new main() function.
Global variables move to local variables and get passed as function arguments, like the nodes dictionary.

Further really basic reformatting.

Comment thread tools/contact_player/contact_player.py Dismissed
Comment thread tools/contact_player/contact_player.py Dismissed
Comment thread tools/contact_player/contact_player.py Dismissed
Comment thread tools/contact_player/contact_player.py Dismissed
Comment thread tools/contact_player/contact_player.py Dismissed
Comment thread tools/contact_player/contact_player.py Dismissed
Comment thread tools/contact_player/contact_player.py Dismissed
@axodentally axodentally mentioned this pull request Jul 16, 2026
1 task
@axodentally

Copy link
Copy Markdown
Collaborator Author

I did not ask for a review of this github-code-quality bot... but dismissed all findings since they are all in the old code, that I did not even touch. This PR only moved old code around.

The refactoring is done in the other PRs.

Therefor none of the comments are relevant.

@gh0st42
gh0st42 merged commit e653e17 into main Aug 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants