refactor(contact_player.py): part1: basic refactoring, move functionality to main() function - #20
Merged
Merged
Conversation
This was referenced Jul 16, 2026
Collaborator
Author
|
This change is part of the following stack:
Change managed by git-spice. |
Collaborator
Author
|
I did not ask for a review of this github-code-quality bot... but dismissed all findings since they are all in the old code, that I did not even touch. This PR only moved old code around. The refactoring is done in the other PRs. Therefor none of the comments are relevant. |
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the main script logic into a new
main()function.Global variables move to local variables and get passed as function arguments, like the
nodesdictionary.Further really basic reformatting.