Add C++ wrapper Simd::SynetMergedConvolution8i - #927
Merged
Conversation
Wrap SimdSynetMergedConvolution8i C API in Simd::SynetMergedConvolution8i with Doxygen docs and a CheckCpp test against the C functions. Co-authored-by: igor.ermolaev <igor.ermolaev@altezza.org>
ermig1979
marked this pull request as ready for review
August 27, 2026 08:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a C++ wrapper for the INT8 merged convolution C API, matching
Synet::MergedConvolution8ifrom ermig1979/Synet (src/Synet/Utils/MergedConvolution.h) and the existingSimd::SynetMergedConvolution32f/Simd::SynetMergedConvolution16bwrappers.Changes
Simd::SynetMergedConvolution8iinsrc/Simd/SimdSynet.hppwith Doxygen docs forInit,Enable,ExternalBufferSize,InternalBufferSize,Info,SetParams,Forward, andClear.TestSynetMergedConvolution8i()insrc/Test/TestCheckCpp.cppcompares the wrapper to the C API (Init/SetParams/Forward, buffer sizes, andInfo).src/Simd/SimdLib.hpoint to the new wrapper.docs/2026.html.prj/txt/DoxygenGroups.txtlists the new class.src/Simd/SimdSynet.hppandsrc/Test/TestCheckCpp.cppare already inprj/vs2022/Simd.vcxproj,prj/vs2022/Simd.vcxproj.filters,prj/vs2022/Test.vcxproj, andprj/vs2022/Test.vcxproj.filters.Validation
CMake Release build with g++ and
./Test "-r=.." -fi=CheckCpp -tt=1 -ts=1frombuild/.