Add C++ wrapper Simd::SynetMergedConvolution16b - #926
Merged
Conversation
Wrap SimdSynetMergedConvolution16b C API in Simd::SynetMergedConvolution16b with Doxygen docs and a CheckCpp test against the C functions. Co-authored-by: igor.ermolaev <igor.ermolaev@altezza.org>
Include SimdDefs.h so SIMD_SYNET_ENABLE tests compile, and pass a valid params array because the 16b C API indexes it even for Identity. Co-authored-by: igor.ermolaev <igor.ermolaev@altezza.org>
ermig1979
marked this pull request as ready for review
August 27, 2026 07:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds C++ wrapper
Simd::SynetMergedConvolution16binsrc/Simd/SimdSynet.hpp, analogous toSynet::MergedConvolution16bfrom the Synetdevbranch (src/Synet/Utils/MergedConvolution.h).The wrapper covers the existing C API:
SimdSynetMergedConvolution16bInitSimdSynetMergedConvolution16bExternalBufferSizeSimdSynetMergedConvolution16bInternalBufferSizeSimdSynetMergedConvolution16bInfoSimdSynetMergedConvolution16bSetParamsSimdSynetMergedConvolution16bForwardChanges
Simd::SynetMergedConvolution16bclass with Doxygen description and usage exampleTestSynetMergedConvolution16b()insrc/Test/TestCheckCpp.cppcompares wrapper output with the C APIdocs/2026.htmlcpp_synetgroup and C API notes updatedTestCheckCpp.cppincludesSimd/SimdDefs.hsoSIMD_SYNET_ENABLEtests actually compileSimdSynet.hppis already listed inprj/vs2022/Simd.vcxprojandprj/vs2022/Simd.vcxproj.filtersondevTest plan
./Test "-r=.." -cc=1 -fi=Sobel -tt=1 -ts=1ranCheckCpp()includingTestSynetMergedConvolution16b()with no wrapper mismatchesAmxBf16-0, 512 outputs with 0 mismatchesStandalone wrapper verification log
CheckCpp and Sobel smoke log