Add C++ wrapper Simd::SynetQuantizedInnerProduct - #922
Merged
Conversation
Provide a Synet-style C++ wrapper around SimdSynetQuantizedInnerProductInit and related C API functions, with Doxygen docs, CheckCpp coverage, and a release 7.2.165 note. Co-authored-by: igor.ermolaev <igor.ermolaev@altezza.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a C++ wrapper
Simd::SynetQuantizedInnerProductanalogous toSynet::QuantizedInnerProductfrom ermig1979/Synet (src/Synet/Utils/InnerProduct.h,devbranch).Changes
Simd::SynetQuantizedInnerProductinsrc/Simd/SimdSynet.hppwrapping:SimdSynetQuantizedInnerProductInitSimdSynetQuantizedInnerProductInternalBufferSizeSimdSynetQuantizedInnerProductExternalBufferSizeSimdSynetQuantizedInnerProductInfoSimdSynetQuantizedInnerProductSetParamsSimdSynetQuantizedInnerProductForwardcpp_synetgroup).Simd::SynetQuantizedInnerProduct.TestSynetQuantizedInnerProduct()insrc/Test/TestCheckCpp.cppcompares wrapper output, buffer sizes andInfo()with the C API.docs/2026.html.prj/txt/DoxygenGroups.txtmentions the new wrapper.src/Simd/SimdSynet.hppis already listed inprj/vs2022/Simd.vcxprojandprj/vs2022/Simd.vcxproj.filters.The wrapper follows the same style as
Simd::SynetInnerProduct16b.Testing
g++,SIMD_SHARED=ON) of the library andTest../Test "-r=.." -cc=1 -fi=SynetQuantizedInnerProduct -tt=1 -ts=1: CheckCpp (includingTestSynetQuantizedInnerProduct) and SynetQuantizedInnerProduct C API tests finished successfully.Simd::SynetQuantizedInnerProduct::Enable()is true; wrapper output matches the C API (0mismatches on a 4x8x16 UINT8/INT8 case with const B and bias). Internal/external buffer sizes match (15704/14344).Info()isAmxBf16::GemmV1for both wrapper and C API.Test/build_and_test_arm64 (13, Release)passed.