Skip to content

erl_lint: Mark records used in record_info/2 as used #11470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhogberg wants to merge 1 commit into
base: maint
Choose a base branch
from
+12 −3
Open

erl_lint: Mark records used in record_info/2 as used #11470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/stdlib/src/erl_lint.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5278,7 +5278,7 @@ check_record_info_call(_Anno,_Aa,[{atom,Ai,Info},{atom,_An,Name}], St) ->
true ->
case St#lint.records of
#{Name := {_,tuple,_}} ->
St;
used_record(Name, St);
#{} ->
add_error(Ai, native_record_illegal_record_info, St)
end;
Expand Down
13 changes: 11 additions & 2 deletions lib/stdlib/test/erl_lint_SUITE.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5695,9 +5695,10 @@ illegal_zip_generator(Config) ->

ok.

%% GH-9694. Only record_info/2 should be checked for illegal_record_info
record_info_0(Config) ->
Ts = [{record_info_0,
Ts = [%% GH-9694. Only record_info/2 should be checked for
%% illegal_record_info
{record_info_0,
<<"-export([f/0]).
record_info() -> ok.
f() -> record_info().
Expand All @@ -5710,6 +5711,14 @@ record_info_0(Config) ->
g() -> record_info(ok).
">>,
[],
[]},
%% ERIERL-1345: record_info/2 should mark tuple records as used
{record_info_2,
<<"-export([h/0]).
-record(rec,{a,b,c}).
h() -> record_info(fields, rec).
">>,
[],
[]}
],
[] = run(Config, Ts),
Expand Down
Loading