Skip to content

webrequest.cpp: fix build with musl libc#16

Open
andrea-adami wants to merge 1 commit into
eriksl:masterfrom
andrea-adami:dev
Open

webrequest.cpp: fix build with musl libc#16
andrea-adami wants to merge 1 commit into
eriksl:masterfrom
andrea-adami:dev

Conversation

@andrea-adami

Copy link
Copy Markdown

fix following error:

| ../../git/src/webrequest.cpp:15:10: fatal error: sys/unistd.h:
No such file or directory
| 15 | #include <sys/unistd.h>

Signed-off-by: Andrea Adami andrea.adami@gmail.com

fix following error:

 | ../../git/src/webrequest.cpp:15:10: fatal error: sys/unistd.h:
 No such file or directory
 |    15 | #include <sys/unistd.h>

Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
@eriksl

eriksl commented Jun 20, 2021

Copy link
Copy Markdown
Owner

Why doesn't musl have this header file?

It may very well be that the code needs declarations from this file.

@persianpros

Copy link
Copy Markdown

@eriksl

Would you please accept this and revert OpenPLi/openpli-oe-core@76b525c ?

@andrea-adami

andrea-adami commented Jun 20, 2021

Copy link
Copy Markdown
Author

Hi,
musl libc just doesn't have it.
If you check under /usr/include/sys, glibc sys/unistd.g is including unistd.h.

In fact it should be sufficient to include the latter, valid for both libc's.
Cheers
A.A.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants