Extend SurfaceLayer for all boundary sides - #3860

Open

ckendrick wants to merge 1428 commits into

erf-model:developmentfrom

llnl:most_walls_cloudchamber

This pull request is big! We're only showing the most recent 250 commits

Commits on Apr 30, 2026

Add idata(k_finest) slot so multi-level Redistribute Assignor places particles correctly across AMR levels without breaking AMReX cic_/mac_interpolate_mapped_z which read idata(k)

debog
and
claude
committed
be7dc43
Move s_dxi_z_finest from class member to namespace scope so AMREX_GPU_MANAGED works under CUDA

debog
and
claude
committed
2f74914

Commits on May 1, 2026

Commits on May 6, 2026

Merge remote-tracking branch 'erfrepo/development' into dg/sdm_w_AMR
debog
committed
a78a4fe

Commits on May 7, 2026

Commits on May 8, 2026

Commits on May 20, 2026

Merge erfrepo/development into dg/sdm_w_cold_processes
debog
committed
3ee7ab3
adding DYCOMS test cases
Hassan Beydoun
committed
af0abd6
Fix SP-mesh and SP-particle build errors in cold-process code
debog
committed
29d9fb8
Merge origin/dg/sdm_w_cold_processes: DYCOMS test cases
debog
committed
02303b8

Commits on May 21, 2026

Clean up DYCOMS prob code: drop unused variables, consolidate duplicate prob-name branches
debog
committed
d0d1a7b
updated input file for DYCOMS2RF01
Hassan Beydoun
committed
47925cc
Merge branch 'dg/sdm_w_cold_processes' of ssh://czgitlab.llnl.gov:7999/erf-model/erf-llnl into dg/sdm_w_cold_processes
Hassan Beydoun
committed
2e96049
Fix Clang DP-mesh/SP-particle narrowing errors in functor brace-initializers
debog
committed
4b6645f
removed commented-out lines from input
debog
committed
5a67179
Remove unused custom rhotheta/moisture forcing flags from DYCOMS2RF01 input
debog
committed
cdefdb3
Merge branch 'development' into dg/sdm_w_cold_processes
debog
committed
e794aaf
removed code quality report
debog
committed
21ad6b1

Commits on May 22, 2026

Commits on May 23, 2026

Regenerate SDM_MoistBubble{2D_AMR1,3D_AMR1,3D_AMR2} gold files for the phaseChange guard restoration
debog
committed
1987181

Commits on May 26, 2026

Add split/merge AMR API stubs + flag + Redistribute hook
debog
committed
1a5cf57

Commits on May 27, 2026

Commits on May 28, 2026

Commits on May 29, 2026

Commits on Jun 1, 2026

Add SDM_Box3D_IceMelt regression test seeding pure ice in a warm box that melts partially over 10 steps, exercising the gradual melt model [run-ci]

debog
and
claude
committed
c6418ad

Commits on Jun 3, 2026

Restrict SDM AMR merges to same log-radius bin (per-cell adaptive range, N_R = target SDs/cell) so only same-size super-droplets combine, preserving the rain-seeding large-droplet tail
debog
committed
a841ac8

Commits on Jun 4, 2026

Commits on Jun 5, 2026

Commits on Jun 11, 2026

Commits on Jun 18, 2026

Commits on Jun 19, 2026

Commits on Jun 22, 2026

Merge branch 'development' into most_walls_dev_sdm_new
ckendrick
committed
0b4471f
SDM SV habit table: function-local static constexpr for host+device

debog
and
claude
committed
5388031

Commits on Jun 23, 2026

Fixed precision-related errors and warnings
debog
committed
4838526
Bugfix: visc coeff needs to be converted to SI units
debog
committed
0110c7c
TerminalVelocity test: recenter graupel band, add Stokes-regime check
debog
committed
01210b5

Commits on Jun 24, 2026

Commits on Jun 25, 2026

Commits on Jun 26, 2026

Clean up branch-unique SDM inputs (DYCOMS/GATE/TempSourceCold); sync DYCOMS with run-repo

debog
and
claude
committed
cb4b060
SDM: add prescribed_w steady-updraft advection option

debog
and
claude
committed
b645679
Merge remote-tracking branch 'origin/llnl/development' into dg/sdm_w_cold_processes
debog
committed
f0a0615
Add SDM ice-process ctests (sublimation/melting/freezing/aggregation/coalescence/riming)

debog
and
claude
committed
413bc1f
Add SDM ice-microphysics example inputs and READMEs in Exec

debog
and
claude
committed
880f98d
Merge remote-tracking branch 'origin/development' into dg/sdm_w_cold_processes
debog
committed
fb87689
Merge branch 'dg/sdm_w_cold_processes' into dg/sdm_fractional_injection [run-ci]
debog
committed
19c95db

Commits on Jun 29, 2026

Removing sublimation shaft test for AMD GPUs
debog
committed
7bfec38
Merge branch 'dg/sdm_w_cold_processes' into dg/sdm_fractional_injection [run-ci]
debog
committed
c2510ac
SDM: per-box high-multiplicity injection [run-ci]

debog
and
claude
committed
9cd00dd

Commits on Jul 1, 2026

Commits on Jul 2, 2026

switch kernel velocity terms

emmacware
authored and
debog
committed
470d8a1
Merge branch 'emma_cold_processes' into 'dg/sdm_w_cold_processes'
debog
committed
706cb41
Merge remote-tracking branch 'origin/dg/sdm_w_cold_processes' into dg/sdm_fractional_injection [run-ci]
debog
committed
aa527fe

Commits on Jul 13, 2026

Merge branch 'dg/sdm_w_cold_processes' into most_walls_dev_sdm_new
ckendrick
committed
4234954
Fix fill boundary issue
ckendrick
committed
0599b59

Commits on Jul 20, 2026

Rebuild FFT solvers on restart
ckendrick
committed
7135871
Fixed GATE readme
debog
committed
7f577af

Commits on Jul 21, 2026

SDM riming: at T>=0C route the collected droplet to meltwater instead of freezing it as rime -- guards the supercooled Heymsfield-Pflaum rime density (erf_esati=0 above 0C gives inf/inf in iceSurfa…
debog
committed
1a19c24

Commits on Jul 22, 2026

SDM: allow zero-mass constant aerosols; require at least one non-zero aerosol per mode
debog
committed
add9e5f

Commits on Aug 2, 2026

SDM: add erf.random_seed input to vary the RNG (init sampling + collisions) per run

debog
and
claude
committed
82661a5

Commits on Aug 10, 2026

Commits on Aug 11, 2026

Merge branch 'development' into fix-SDM-issues
debog
authored
fa16bdc
Use ThreadSanitizer for the threaded job; assert the sampled tail index is in range [run-ci]
debog
committed
d2388df
Merge erfrepo/development into dg/sdm_w_cold_processes

debog
and
claude
committed
67b8a5d
Update RadiationSimple to current IRadiation interface (double time/dt, updated_lsm)

debog
and
claude
committed
b106ce3
Merge fix-SDM-issues into dg/sdm_w_cold_processes; apply the tiling fix to the cold-branch saturation-ratio loops

debog
and
claude
committed
b6ecd59
Restore lsf_data/nudge_data sizing and the RadiationSimple branch lost when upstream relocated the constructors

debog
and
claude
committed
6565655
Advertise ice, snow and graupel plot variables for the super-droplet moisture model

debog
and
claude
committed
135324f
Drop input keys upstream no longer reads; correct recycle-bounds names and terrain text in the SDM docs

debog
and
claude
committed
449de0d
Rename TemperatureSourceSpatial_cold to SDM_Congestus3D_cold to match the warm case

debog
and
claude
committed
de31b91
Reject a species that is already modeled; drop the duplicate ice entry from the aggregation decks

debog
and
claude
committed
7bd5cb3
Remove local agent config and notes accidentally committed under .claude

debog
and
claude
committed
8f18218
Point LC CI back at the main gold-file ref

debog
and
claude
committed
115e846
Restore SDM_Congestus3D and SDM_RICO3D golds as whole plotfiles; the merge had mixed two box layouts

debog
and
claude
committed
1fc587c
Strip trailing whitespace from new decks and profile output

debog
and
claude
committed
c8d63fd
Regenerate SDM_SublimationShaft, SDM_Congestus3D and SDM_RICO3D golds after the upstream merge

debog
and
claude
committed
d2c1246
Drop the ThreadSanitizer and AddressSanitizer CI jobs

debog
and
claude
committed
31b9354
Merge branch 'fix-SDM-issues' into dg/sdm_w_cold_processes
debog
committed
e1a5f18
Run the gated SDM cases as assertion-checked smoke tests in the GNU build

debog
and
claude
committed
438bcf4
Fix single-precision build: keep the injected super-droplet count in Real [run-ci]

debog
and
claude
committed
bf626c7
Leave the coalescence box tests out of the smoke pass; the kernels have unit tests

debog
and
claude
committed
2375c3b

Commits on Aug 12, 2026

Update the moisture capability truth table for the super-droplet ice variables

debog
and
claude
committed
749e702
Fix single-precision build in the large-scale forcing update; drop an unused variable [run-ci]

debog
and
claude
committed
da82528
Temporarily point LC CI at the SDM_w_ice gold-file ref

debog
and
claude
committed
d3f78f3
Revert "Temporarily point LC CI at the SDM_w_ice gold-file ref"
debog
committed
a76f7bb
Rename fo to nbr_off and ofs, and fix a hyphenated word, to satisfy codespell

debog
and
claude
committed
4ad19ec
Merge remote-tracking branch 'erfrepo/development' into dg/sdm_w_cold_processes
debog
committed
ebaa290
Build the super-droplet microphysics unit tests only when particles are enabled

debog
and
claude
committed
cfd8516
Silence unused-parameter, unused-variable and shadow warnings in the cold-process code

debog
and
claude
committed
30df3c4
Merge branch 'development' into dg/sdm_w_cold_processes
debog
authored
5a6ca88
Rename the inner reduction locals so they no longer shadow the ReduceData object

debog
and
claude
committed
62acb3e

Commits on Aug 13, 2026

Commits on Aug 14, 2026

Clean up old code
ckendrick
committed
38b8734
Merge branch 'dg/sdm_w_cold_processes' into cloudchamber
ckendrick
committed
912b45c
Update unit test for new diffusion call signature
ckendrick
committed
515c05d
Fix warning
ckendrick
committed
c831d0f
Update goldfile branch
ckendrick
committed
ab46dbf
Cleanup diffusion
ckendrick
committed
a123d19
Remove unused variables
ckendrick
committed
2102b69
Update checkpoint names used for single face case
ckendrick
committed
fe1fce0
Update PBL MOST average indices
ckendrick
committed
e492639

Commits on Aug 15, 2026

Add missing test
ckendrick
committed
3049612
Turn off FFT option for CI
ckendrick
committed
7d7f8bc
Fix warnings
ckendrick
committed
c570b75
Add gold file for MOST walls test
ckendrick
committed
9575e34
Merge branch 'development' into cloudchamber
ckendrick
committed
3841117
Skip test if not built with FFT enabled
ckendrick
committed
fa7cadd
Add option for FFT to LC CI and temporarily enable
ckendrick
committed
0c790aa

Commits on Aug 17, 2026

Style
ckendrick
committed
a37b33b
Add doc section for surface layer on sides
ckendrick
committed
e36532b
Remove goldfile treated as text
ckendrick
committed
910e237
Readd goldfile as binary
ckendrick
committed
e100771
Move LC gitlab goldfile ref back to main
ckendrick
committed
1f0f978
Merge remote-tracking branch 'upstream/development' into cloudchamber
ckendrick
committed
96560ae

Commits on Aug 27, 2026

Fix stress mapping on x face

ckendrick
authored and
Coleman James Kendrick
committed
ba74318
Fix review issues

ckendrick
authored and
Coleman James Kendrick
committed
a3fa17e
Minor cleanup for plotfile variables

ckendrick
authored and
Coleman James Kendrick
committed
6a0ae28

Commits on Aug 28, 2026

Commits on Aug 29, 2026

Fix more unused parameter warnings
ckendrick
committed
293811a
Merge remote-tracking branch 'upstream/development' into cloudchamber
ckendrick
committed
909a4a9

Commits on Sep 1, 2026

Add fixes from review
ckendrick
committed
ad94def
Generalize tau transpose writes for face corners
ckendrick
committed
31fe7d5
Add unit tests for SurfaceLayer and MOSTAverage on side walls
ckendrick
committed
6ba8b6f
Update gold file
ckendrick
committed
d31a017
Cleanup MOSTAverage k index functions and add tests
ckendrick
committed
8773d2f
Merge remote-tracking branch 'upstream/development' into cloudchamber
ckendrick
committed
7b0db50
Fix codespell error
ckendrick
committed
de02813

Commits on Sep 2, 2026

Split out unit tests into serial and parallel, add tiling checks
ckendrick
committed
01532dc
Fix tiling issues for planar average/qsurf
ckendrick
committed
9d4a5c3
Updates for grid check and lateral boundary fill
ckendrick
committed
bd44e10

Commits on Sep 3, 2026

Add extra asserts for unsupported options
ckendrick
committed
c29b501
Add additional asserts on layouts, update tiling and no-terrain paths
ckendrick
committed
2570b30
Remove unused w rot field and add additional checks
ckendrick
committed
642aada
Update k indices for non terrain to be wall-relative
ckendrick
committed
7dd1317
Add check for regional average difference
ckendrick
committed
23fbd17
Merge remote-tracking branch 'upstream/development' into cloudchamber
ckendrick
committed
8c741c0
Update gold file
ckendrick
committed
bd8959c

Commits on Sep 5, 2026

Merge remote-tracking branch 'upstream/development' into cloudchamber
ckendrick
committed
e990de4
Update new get_ng_fill and extrap function for lateral faces
ckendrick
committed
0a579e3
Cleanup redundant runtime assertions
ckendrick
committed
ea29a35

Commits on Sep 8, 2026

Fix warnings and CUDA/HIP builds
ckendrick
committed
f3bc6ca
Fix CUDA extended lambda in unit tests
ckendrick
committed
003db8e