Skip to content

dynamic modules: add abi.h to go mod vendor tree #44395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdamEAnderson wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

dynamic modules: add abi.h to go mod vendor tree #44395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions source/extensions/dynamic_modules/abi/abi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// Package abi contains the C ABI header for Envoy dynamic modules.
//
// This file exists so that `go mod vendor` includes this directory.
// Without a .go file, the Go toolchain skips this directory during
// vendoring, which causes the abi.h header (needed by the Go SDK's
// cgo include) to be missing from the vendor tree.
package abi
Comment on lines +1 to +7
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To align with Go's idiomatic practices, it is recommended to name files that solely contain package documentation and a package clause as doc.go. This convention makes the file's purpose—to ensure the directory is treated as a Go package—immediately clear to other developers.

Consider renaming abi.go to doc.go.

Loading