fix(validator): reject structurally invalid PAT stores - #1658
Open
taooutsider wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
miner_pats.jsondecodes to the declaredlist[dict]contract.load_all_pats()tolerant for scoring snapshots while making writes fail closed.Problem
The PAT store already handled malformed JSON and I/O errors, but syntactically valid JSON with the wrong structure was accepted. Values such as
null,{}, or["not an entry"]causedload_all_pats()to return the wrong type and could raiseTypeErrororAttributeErrorin scoring and write paths.The fix introduces a specific
PatStoreFormatError, preserves the tolerant read-only scoring behavior, and prevents invalid stores from being overwritten.This is separate from #1481 / #1486, which addressed malformed or unreadable store data rather than valid JSON with an invalid schema.
Related Issues
No new issue. Public issue creation is currently restricted for this repository.
Type of Change
Testing
Validation completed:
55 passedin focused PAT storage/handler tests971 passedin the full test suitegit diff --checkpassedChecklist