Repository navigation
Remove sidekiq/job_retry dependency - #43
Merged
Merged
Conversation
kaisen-san
approved these changes
Aug 18, 2026
kaisen-san
requested changes
Aug 18, 2026
kaisen-san
left a comment
Contributor
There was a problem hiding this comment.
No worries. Thanks for putting a fix together! Seems like some tests failed, though. Could you look into it?
Contributor
Author
|
Thanks @kaisen-san I've pushed a fix that should sort it. It was failing due to Sidekiq v4 defining that constant in a different place to 5+: https://github.com/sidekiq/sidekiq/blob/fe43e1cbcd0498a37a69581ace523bc36630cd3f/lib/sidekiq/middleware/server/retry_jobs.rb#L67 We could do something like wrap the require in a a begin/rescue, and then require it from the different location to support Sidekiq 4. But maybe better not to reach into Sidekiq's internals and just define the constant here to match? Let me know what you think. |
Contributor
|
Yeah, that makes sense to me! |
kaisen-san
approved these changes
Aug 19, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made an oversight in the recent fix PR #42 and not required this. Without it when the fallback max retry attempts value gets accessed,
Sidekiq::JobRetry::DEFAULT_MAX_RETRY_ATTEMPTSis not defined.Included a spec which fails when the sidekiq/job_retry module is not required.
Thanks for reviewing and merging the previous PR promptly, apologies for missing this!