Use forward slashes in SFZ paths for Linux/macOS compatibility#1
Draft
endolith wants to merge 1 commit into
Draft
Use forward slashes in SFZ paths for Linux/macOS compatibility#1endolith wants to merge 1 commit into
endolith wants to merge 1 commit into
Conversation
Windows-style backslashes in default_path and relative sample paths break or are unreliable on Linux and macOS SFZ engines. Forward slashes are accepted on all common platforms when the WAV folders sit next to the SFZ as distributed. Co-authored-by: endolith <endolith@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All
.sfzfiles used Windows-style backslashes indefault_pathand in Snare2’s nestedsample=paths. Many SFZ players on Linux and macOS treat those literally and fail to load WAVs next to the instrument.Changes
\with/in every affecteddefault_pathandsample=line (13 instruments).Toms.sfzwas unchanged (includes only; no path separators).Notes
The readme still mentions velocity transitions as a known limitation; that is an artistic/tuning concern, not addressed here.