fix: resolve #3025 — Pet Dæmon: Guest code evaluation requests#3167
Open
tudragon154203 wants to merge 2 commits intoendojs:masterfrom
Open
fix: resolve #3025 — Pet Dæmon: Guest code evaluation requests#3167tudragon154203 wants to merge 2 commits intoendojs:masterfrom
tudragon154203 wants to merge 2 commits intoendojs:masterfrom
Conversation
Fixes endojs#3025 Signed-off-by: tudragon154203 <76395825+tudragon154203@users.noreply.github.com>
Fixes endojs#3025 Signed-off-by: tudragon154203 <76395825+tudragon154203@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: resolve #3025 — Pet Dæmon: Guest code evaluation requests
Problem
Severity:
High| File:packages/pet-daemon/src/guest-evaluate.jsCreate a new module that provides the
evaluatefunction to guest code. This function should accept a program string and package it as an evaluation request message to be sent to the host via the mail system. The function should return a promise that resolves or rejects based on the host's response (allow/deny).Solution
Export a
makeGuestEvaluator(mailbox)function that returns anevaluate(program)async function. Theevaluatefunction should construct a structured mail message of type 'evaluation-request' containing the source code, send it through the mailbox, and await a response message of type 'evaluation-response'. Include source location metadata and a unique request ID for correlation.Changes
packages/pet-daemon/src/guest-evaluate.js(new)packages/pet-daemon/src/host-evaluate-handler.js(new)Testing
Generated by ContribAI v5.15.0