Skip to content

fix(compartment-mapper): handle async parsers#3160

Closed
boneskull wants to merge 1 commit intoboneskull/module-source-pipelinefrom
boneskull/compartment-mapper-pipeline
Closed

fix(compartment-mapper): handle async parsers#3160
boneskull wants to merge 1 commit intoboneskull/module-source-pipelinefrom
boneskull/compartment-mapper-pipeline

Conversation

@boneskull
Copy link
Copy Markdown
Member

This updates the code and types to handle async parsers. Currently, there are no async parsers in @endo/compartment-mapper, which is a reasonable excuse for why they were not working.

While this looks like a much was changed, it is mostly type-related. Some extra guards were added and code split out within map-parser.js to support both the async and sync parser use-cases, while maximizing logic reuse.

@boneskull
Copy link
Copy Markdown
Member Author

boneskull commented Apr 4, 2026

Warning

This PR is part of a stack and targets branch boneskull/module-source-pipeline, not master.
DO NOT MERGE until feat(module-source): expose createModuleSourcePasses() #3159 is merged into master.

📚 Pull Request Stack


Managed by gh-stack

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 4, 2026

⚠️ No Changeset found

Latest commit: 0dbb69a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This updates the code and types to handle async parsers. Currently, there are no async parsers in
`@endo/compartment-mapper`, which is a reasonable excuse for why they were not working.

While this looks like a much was changed, it is mostly type-related.  Some extra guards were added
and code split out within `map-parser.js` to support both the async and sync parser use-cases,
while maximizing logic reuse.
@boneskull
Copy link
Copy Markdown
Member Author

this needs to fold in to #3158

@boneskull boneskull closed this Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lavamoat performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant