fix(compartment-mapper): handle async parsers#3160
Closed
boneskull wants to merge 1 commit intoboneskull/module-source-pipelinefrom
Closed
fix(compartment-mapper): handle async parsers#3160boneskull wants to merge 1 commit intoboneskull/module-source-pipelinefrom
boneskull wants to merge 1 commit intoboneskull/module-source-pipelinefrom
Conversation
Member
Author
|
Warning This PR is part of a stack and targets branch 📚 Pull Request Stack
Managed by gh-stack |
|
This updates the code and types to handle async parsers. Currently, there are no async parsers in `@endo/compartment-mapper`, which is a reasonable excuse for why they were not working. While this looks like a much was changed, it is mostly type-related. Some extra guards were added and code split out within `map-parser.js` to support both the async and sync parser use-cases, while maximizing logic reuse.
c3239b5 to
0fb7919
Compare
ec8e135 to
0dbb69a
Compare
This was referenced Apr 4, 2026
Member
Author
|
this needs to fold in to #3158 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the code and types to handle async parsers. Currently, there are no async parsers in
@endo/compartment-mapper, which is a reasonable excuse for why they were not working.While this looks like a much was changed, it is mostly type-related. Some extra guards were added and code split out within
map-parser.jsto support both the async and sync parser use-cases, while maximizing logic reuse.