Fix preprocessor logic error in pthread_mutex_trylock.c. NFC#26753
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Apr 22, 2026
Merged
Fix preprocessor logic error in pthread_mutex_trylock.c. NFC#26753sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
This was a mistake from emscripten-core#24607. The only effect was that this extra (redundant) check was mistakenly included in release builds where its technically not needed.
kripken
approved these changes
Apr 22, 2026
| if ((type & 15) == PTHREAD_MUTEX_NORMAL) return 0; | ||
| #if defined(__EMSCRIPTEN__) && !defined(NDEBUG) | ||
| // Under emscripten we can get here for normal mutexes too, but only in debug | ||
| // Jbuilds (where we track ownership purely for debug purposes). |
Member
There was a problem hiding this comment.
Suggested change
| // Jbuilds (where we track ownership purely for debug purposes). | |
| // builds (where we track ownership purely for debug purposes). |
Collaborator
Author
There was a problem hiding this comment.
Sorry, will fix in followup.
sbc100
added a commit
that referenced
this pull request
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a mistake from #24607. The only effect was that this extra (redundant) check was mistakenly included in release builds where its technically not needed.