Skip to content

feat: switch core StatefulSet to in-place rolling updates #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keynslug merged 51 commits into from
Apr 8, 2026

chore: leave comment about `syncCoreSet` responsibilities

1f32248
Select commit
Loading
Failed to load commit list.
Merged

feat: switch core StatefulSet to in-place rolling updates #1179

chore: leave comment about `syncCoreSet` responsibilities
1f32248
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 8, 2026 in 0s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

❌ Patch coverage is 83.58663% with 162 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main-3.x@a2885da). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/controller/sync_core_set.go 79.18% 37 Missing and 14 partials ⚠️
internal/controller/load_state.go 61.53% 19 Missing and 11 partials ⚠️
internal/controller/add_replicant_set.go 84.21% 10 Missing and 2 partials ⚠️
internal/controller/ds_update_replica_sets.go 64.00% 6 Missing and 3 partials ⚠️
internal/controller/rebalance_controller.go 0.00% 8 Missing ⚠️
internal/controller/sync_emqx_config.go 61.11% 7 Missing ⚠️
internal/controller/update_emqx_status.go 96.47% 5 Missing and 1 partial ⚠️
internal/controller/util/pod.go 75.00% 4 Missing and 2 partials ⚠️
internal/controller/add_core_set.go 95.57% 3 Missing and 2 partials ⚠️
internal/emqx/api/evacuation.go 50.00% 4 Missing and 1 partial ⚠️
... and 11 more
Additional details and impacted files 
@@             Coverage Diff             @@
##             main-3.x    #1179   +/-   ##
===========================================
  Coverage            ?   74.17%           
===========================================
  Files               ?       48           
  Lines               ?     3667           
  Branches            ?        0           
===========================================
  Hits                ?     2720           
  Misses              ?      801           
  Partials            ?      146

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov