[bot] Fix #1242: Admin content edit route should preserve locale for slug-based i18n entries#1307
Open
emdashbot[bot] wants to merge 3 commits into
Open
[bot] Fix #1242: Admin content edit route should preserve locale for slug-based i18n entries#1307emdashbot[bot] wants to merge 3 commits into
emdashbot[bot] wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: b238b6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | b238b6e | Jun 03 2026, 08:17 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-playground | b238b6e | Jun 03 2026, 08:17 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-demo-cache | b238b6e | Jun 03 2026, 08:17 PM |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
Contributor
Overlapping PRsThis PR modifies files that are also changed by other open PRs:
This may cause merge conflicts or duplicated work. A maintainer will coordinate. |
…e and write handlers (#1242)
The create-new flow navigated to the edit route without a locale search param, while edit links and translation navigation now append one. That asymmetry made the i18n e2e test's full-URL equality assertion fail when navigating back to the default-locale entry.
Main's #1302 already added locale reading to the PUT content-update route. Drop this branch's duplicate declaration (kept main's request.url form, which the existing route test exercises) so the merged PUT handler has a single `locale`. The branch's remaining core contribution is locale on DELETE and the publish/unpublish/schedule/ discard-draft sub-action routes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1242.
@ascorbic confirmed this fix resolves the issue:
See #1242 for the investigation trail.
Opened automatically by the investigation bot. A maintainer should review before merge.