RFC#560 - {{eq}}, {{neq}} as keywords#21312
Open
NullVoxPopuli-ai-agent wants to merge 1 commit intoemberjs:mainfrom
Open
RFC#560 - {{eq}}, {{neq}} as keywords#21312NullVoxPopuli-ai-agent wants to merge 1 commit intoemberjs:mainfrom
NullVoxPopuli-ai-agent wants to merge 1 commit intoemberjs:mainfrom
Conversation
b25e076 to
ba28d4e
Compare
Add equality helpers and register them as built-in keywords so they no longer need to be imported in strict-mode (gjs/gts) templates. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ba28d4e to
1a1ba04
Compare
NullVoxPopuli
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements RFC #560 — adds
eqandneqas new helpers and strict-mode keywords.@glimmer/runtimeequses strict equality (===),nequses strict inequality (!==)@ember/helperwith YUIDoc and Opaque type interfacesNew files
packages/@glimmer/runtime/lib/helpers/{eq,neq}.ts— helper implementationspackages/@glimmer-workspace/integration-tests/test/keywords/{eq,neq}-test.ts— tests with explicit scopepackages/@glimmer-workspace/integration-tests/test/keywords/{eq,neq}-runtime-test.ts— runtime keyword testsModified files
packages/@glimmer/runtime/index.ts— exportspackages/@ember/helper/index.ts— re-exports with docspackages/@ember/template-compiler/lib/compile-options.ts— keyword registrationpackages/@ember/template-compiler/lib/plugins/auto-import-builtins.ts— AST rewritingsmoke-tests/scenarios/basic-test.ts— gjs smoke testtests/docs/expected.js— docs coverage allowlistTest plan
eq: equal numbers, unequal numbers, equal stringsneq: unequal numbers, equal numbers🤖 Generated with Claude Code