Skip to content

Add ESLint rule to disallow barrel/entrypoint imports #21296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
NullVoxPopuli-ai-agent wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add ESLint rule to disallow barrel/entrypoint imports #21296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3b5e33
Add custom ESLint rule to disallow barrel/entrypoint imports
NullVoxPopuli Apr 4, 2026
55c5c80
Rewrite no-barrel-imports rule with auto-fix for all barrel imports
NullVoxPopuli Apr 4, 2026
3a8ea31
Include correct import paths in error messages and handle export *
NullVoxPopuli Apr 4, 2026
714c761
Only flag actual barrels, not standalone modules with index.ts
NullVoxPopuli Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ import nodePlugin from 'eslint-plugin-n';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import pluginJs from '@eslint/js';
import { createRequire } from 'node:module';

const require = createRequire(import.meta.url);
const noBarrelImports = require('./eslint/rules/no-barrel-imports.js');

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
Expand Down Expand Up @@ -41,6 +45,11 @@ export default [
plugins: {
'ember-internal': emberInternal,
'disable-features': disableFeatures,
local: {
rules: {
'no-barrel-imports': noBarrelImports,
},
},
},

linterOptions: {
Expand Down Expand Up @@ -78,6 +87,11 @@ export default [
'disable-features/disable-generator-functions': 'error',
// Doesn't work with package.json#exports
'import/no-unresolved': 'off',

// Prevent importing from barrel/entrypoint files in internal packages.
// Source files should import directly from the specific lib/ file to
// enable proper tree-shaking.
'local/no-barrel-imports': 'error',
},
},
...tseslint.configs.recommended.map((config) => ({
Expand Down
Loading
Loading