Change debug thread dump log level from error to info#647
Open
TheDGOfficial wants to merge 1 commit intoembeddedt:26.1from
Open
Change debug thread dump log level from error to info#647TheDGOfficial wants to merge 1 commit intoembeddedt:26.1from
TheDGOfficial wants to merge 1 commit intoembeddedt:26.1from
Conversation
Prevents silly people assuming its an error condition. They shouldn't be enabling the debug options in the first place, and they will probably still think its an error because of the scary stack trace they can't understand, but i think making it info log level will be more sensible at least. I've not made it debug log level but info instead intentionally, since that would cause it to be invisible for most people instead. An argument against this change would be that info instead of error would make it go to stdout instead of stderr or make it harder to see through other log lines; i can change it to warn log level if desired. Relevant: decce6/Ixeris#100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents silly people assuming its an error condition. They shouldn't be enabling the debug options in the first place, and they will probably still think its an error because of the scary (for end-users) stack trace they can't understand, but i think making it info log level will be more sensible at least.
I've not made it debug log level but info instead intentionally, since debug log level would cause it to be invisible for most people instead.
An argument against this change would be that info instead of error would make it go to stdout instead of stderr or make it harder to see through other log lines; shouldn't be an issue since both are outputted to latest.log but i can change it to warn log level if desired, but feel free to close this PR if this not something you care enough about or want to keep it as error log level.
Relevant: decce6/Ixeris#100