Skip to content

fix: allow passing array to query parameters #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abihf wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: allow passing array to query parameters #253

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d8c435
feat: allow passing array to query parameters
abihf Mar 19, 2026
2023637
Add continue statement in query processing loop
abihf Mar 19, 2026
2c46bf2
Fix indentation for continue statement
abihf Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/treaty2/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ const createProxy = (

let q = ''
if (query) {
const append = (key: string, value: unknown) => {
const append = (key: string, value: unknown, isArray = false) => {
// Explicitly exclude null and undefined values from url encoding
// to prevent parsing string "null" / string "undefined"
if (value === undefined || value === null) return
Expand All @@ -270,7 +270,7 @@ const createProxy = (

q +=
(q ? '&' : '?') +
`${encodeURIComponent(key)}=${encodeURIComponent(
`${encodeURIComponent(key)}${isArray ? '[]' : ''}=${encodeURIComponent(
typeof value === 'object'
? JSON.stringify(value)
: value + ''
Expand All @@ -279,9 +279,7 @@ const createProxy = (

for (const [key, value] of Object.entries(query)) {
if (Array.isArray(value)) {
for (const v of value) append(key, v)

continue
for (const v of value) append(key, v, true)
}

append(key, value)
Expand Down