Do not show membership/profile/topic events in public rooms#33192
Draft
bxdxnn wants to merge 1 commit intoelement-hq:developfrom
Draft
Do not show membership/profile/topic events in public rooms#33192bxdxnn wants to merge 1 commit intoelement-hq:developfrom
bxdxnn wants to merge 1 commit intoelement-hq:developfrom
Conversation
Member
|
Please write tests before seeking review |
92c71ca to
590238c
Compare
t3chguy
reviewed
Apr 20, 2026
Member
t3chguy
left a comment
There was a problem hiding this comment.
Dismissing code review until Product reviews it
Contributor
|
As I already commented on the Android PR, this topic need comprehensive handling not local patches for specific use cases or pain: element-hq/element-x-android#6360 (comment) From product/design perspective we can't accept this as is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See element-hq/element-x-android#6360
Checklist
public/exportedsymbols have accurate TSDoc documentation.