Replace toasts fixture in playwright-common with utility functions.#33152
Draft
andybalaam wants to merge 1 commit intodevelopfrom
Draft
Replace toasts fixture in playwright-common with utility functions.#33152andybalaam wants to merge 1 commit intodevelopfrom
andybalaam wants to merge 1 commit intodevelopfrom
Conversation
andybalaam
force-pushed
the
andybalaam/toasts-as-free-functions
branch
2 times, most recently
from
91792bb to
5b132e7
Compare
andybalaam
force-pushed
the
andybalaam/toasts-as-free-functions
branch
from
5b132e7 to
7a9ba99
Compare
Just because it seems less magic and still convenient.
andybalaam
force-pushed
the
andybalaam/toasts-as-free-functions
branch
from
7a9ba99 to
65c32e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just because it seems less magic and still convenient.
As discussed here: #33119 (comment)
Checklist
public/exportedsymbols have accurate TSDoc documentation.