Distinguish an unverifiable device from a unverified device#33115
Draft
Distinguish an unverifiable device from a unverified device#33115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33089
The Sessions interface currently treats a unverified and unverifiable device as nearly the same thing visually, even though it's not a failure state to have some sessions that don't use crypto (e.g. user scripts). When this is the case, use a neutral color to indicate that the session isn't trusted or untrusted.
TODO: Figure out from Design/Crypto which icon is appropriate for displaying neutrality.
Checklist
public/exportedsymbols have accurate TSDoc documentation.