refactor: use more production code, fewer mocks in github tests #1943
Electron Faraday / faraday/cage
Started
2026-05-13 01:53:02
ago
Waiting for approvals (0/1)
@ckerr has write access to electron/fiddle and the head branch lives in this repository, so this pull request requires 1 approval before this check passes. It currently has 0 approvals — 1 more needed.
Details
Status
| Author | @ckerr |
| Author trust | ✅ trusted |
| Why | @ckerr has write access to electron/fiddle and the head branch lives in this repository |
| Required approvals | 1 |
| Current approvals | 0 (none) |
| Result | waiting — needs 1 more approval |
To make this check pass
Get 1 more approval from maintainers — users with write, maintain, or admin permission on electron/fiddle.
What counts:
- ✅ An approving review from a maintainer who has not already approved and has not put a commit in this pull request.
- 🚫 A review from the pull request author or anyone who authored or committed a commit in this pull request.
- 🚫 Reviews from users without write access.
- 🚫 Reviews from bots not paired with this author.
⚠️ A maintainer requesting changes or dismissing their review removes their earlier approval.
The check re-evaluates automatically when a review is submitted, edited, or dismissed.
What is this? See electron/faraday.
Loading