Fix agent SIGINT abort context ordering#4399
Merged
Merged
Conversation
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4399 +/- ##
==========================================
- Coverage 59.46% 56.04% -3.42%
==========================================
Files 304 259 -45
Lines 30626 26983 -3643
Branches 8335 7502 -833
==========================================
- Hits 18211 15122 -3089
+ Misses 12397 11846 -551
+ Partials 18 15 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samwillis
approved these changes
May 23, 2026
Contributor
samwillis
left a comment
There was a problem hiding this comment.
LGTM
that flake was annoying!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Note: broader agents-runtime typecheck/test runs still fail in this worktree because of existing dependency/linkage issues (missing/mismatched pino, cron-parser, @mariozechner/pi-agent-core, localOnlyCollectionOptions, etc.).