Performance improvements part2#45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves subscription lookup performance for agents with larger subscription lists while preserving the fast path for small lists.
subcriptionssorted by signal name on insert.sigilsSubscriptionBinarySearchThresholdto avoid regressing the common single-signal case.AgentActorsubscriptions as well.AnySigilNamewildcard lookup.tests/tbenchmarks3.nim, a multi-signal fanout benchmark with 6 signals x 6 slots.Performance Notes
The small-list threshold keeps
tests/tbenchmarks.nimclose to the previous single-subscription behavior:The new multi-signal benchmark stresses 36 subscriptions and exercises the binary-search path:
Local samples showed the multi-signal emit loop dropping from the earlier linear-scan sample around
283 msto roughly58-73 ms.Testing
Ran: