[windows] FIx pipeline to set file hash for event 26#18501
Open
marc-gr wants to merge 1 commit intoelastic:mainfrom
Open
[windows] FIx pipeline to set file hash for event 26#18501marc-gr wants to merge 1 commit intoelastic:mainfrom
marc-gr wants to merge 1 commit intoelastic:mainfrom
Conversation
8ee47e0 to
9bd98d3
Compare
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
| changes: | ||
| - description: Map Sysmon event 26 file delete hashes to `file.hash` instead of `process.hash`. | ||
| type: bugfix | ||
| link: https://github.com/elastic/integrations/pull/18501 |
There was a problem hiding this comment.
🟠 High windows/changelog.yml:6
The changelog entry for version 3.8.2 uses https://github.com/elastic/integrations/pull/1 as the link, which is a placeholder PR number. Every other entry in this file references actual PR numbers (e.g., pull/18210, pull/17921). This will mislead anyone tracing the change to its originating PR. Consider updating to the correct PR number.
Suggested change
| link: https://github.com/elastic/integrations/pull/18501 | |
| link: https://github.com/elastic/integrations/pull/1 |
🤖 Copy this AI Prompt to have your agent fix this:
In file packages/windows/changelog.yml around line 6:
The changelog entry for version `3.8.2` uses `https://github.com/elastic/integrations/pull/1` as the link, which is a placeholder PR number. Every other entry in this file references actual PR numbers (e.g., `pull/18210`, `pull/17921`). This will mislead anyone tracing the change to its originating PR. Consider updating to the correct PR number.
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
FIx pipeline to set file hash for event 26
Checklist
changelog.ymlfile.