[PostgreSQL] Add checkpointer data stream#18428
Open
giorgi-imerlishvili-elastic wants to merge 2 commits intoelastic:mainfrom
Open
[PostgreSQL] Add checkpointer data stream#18428giorgi-imerlishvili-elastic wants to merge 2 commits intoelastic:mainfrom
giorgi-imerlishvili-elastic wants to merge 2 commits intoelastic:mainfrom
Conversation
giorgi-imerlishvili-elastic
added
enhancement
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
| logging_collector = 'on' | ||
| log_directory = '/var/log/postgresql' | ||
| log_line_prefix = '%m [%p] %q%u@%d ' | ||
| EOF |
There was a problem hiding this comment.
🟢 Low docker-entrypoint-initdb.d/0-enable-logging.sh:21
The script sets log_directory = '/var/log/postgresql' and logging_collector = 'on' but does not ensure the directory is writable by PostgreSQL. The parent-level script at packages/postgresql/_dev/deploy/docker/docker-entrypoint-initdb.d/0-enable-logging.sh includes chmod a+wx /var/log/postgresql for this purpose. Without this, the logging collector fails to write and PostgreSQL may crash or run without logs, breaking the checkpointer test environment.
+EOF
+
+chmod a+wx /var/log/postgresql🤖 Copy this AI Prompt to have your agent fix this:
In file packages/postgresql/data_stream/checkpointer/_dev/deploy/docker/docker-entrypoint-initdb.d/0-enable-logging.sh around line 21:
The script sets `log_directory = '/var/log/postgresql'` and `logging_collector = 'on'` but does not ensure the directory is writable by PostgreSQL. The parent-level script at `packages/postgresql/_dev/deploy/docker/docker-entrypoint-initdb.d/0-enable-logging.sh` includes `chmod a+wx /var/log/postgresql` for this purpose. Without this, the logging collector fails to write and PostgreSQL may crash or run without logs, breaking the checkpointer test environment.
💔 Build Failed
Failed CI StepsHistory |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Adds checkpointer data stream metrics introduced in PostgreSQL 17
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots