[Prometheus Remote Write] Update request size limits by gizas · Pull Request #16962 · elastic/integrations

gizas · 2026-01-14T14:32:28Z

Dont merge until ^9.2.4 || ^9.3.1 || ^9.4.0 are released

Enhancement

Proposed commit message

WHAT: Adds request size limits configuration variables in the elastic agent policy for the remote_write datastream.
WHY: In order to provide configuration options for max_compressed_body_bytes and max_decoded_body_bytes, after [Prometheus] Remote - Write: Enforce Maxdecoding Length check beats#48218

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.
I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Clone this pr
Navigate to integrations/packages/prometheus and run elastic-package build
elastic-package stack up -d -v --version=9.2.4 (or later)

Related issues

Closes #[Prometheus Remote Write] Configurable size limits on incoming requests for remote_write metricset (max_compressed_body_bytes, max_decoded_body_bytes) #16679

Screenshots

Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>

gizas · 2026-01-14T14:33:13Z

 metrics_count: {{metrics_count}}
 rate_counters: {{rate_counters}}
 use_types: {{use_types}}
+max_compressed_body_bytes: {{max_compressed_body_bytes}}


See beats relevant config options: https://github.com/elastic/beats/blob/main/metricbeat/module/prometheus/remote_write/config.go#L35C58-L35C80

gizas · 2026-01-14T14:34:00Z

 conditions:
  kibana:
-    version: "^8.16.0 || ^9.0.0"
+    version: "^9.2.4 || ^9.3.1 || ^9.4.0"


According to https://github.com/elastic/beats/pull/48218/files#diff-3bca358ec7bb955db5fa88789cf4e1155ee015b30b28abd2b1892725b52190afR63

I don't think changing kibana version to this is a good idea.
Any future bugfixes will be skipped for 18.9, 9.0, 9.1, 9.3.0.
Can we instead the agent version requirment for this configuration int he documentation of the conig parameters ?

See doc: update doc

Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>

gizas · 2026-01-26T09:55:24Z

@elastic/obs-infraobs-integrations can I have a review here please?

Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>

…ns into prometheus_body_bytes

gizas · 2026-01-28T07:55:02Z

@elastic/obs-infraobs-integrations kind reminder please

jsoriano · 2026-01-28T21:59:32Z

 conditions:
  kibana:
-    version: "^8.16.0 || ^9.0.0"
+    version: "^9.2.4 || ^9.3.1 || ^9.4.0"


^9.2.4 already includes ^9.3.1 and ^9.4.0, were you intending to set something like ~9.2.4 || ~9.3.1 || ^9.4.0?

Let me clarify with an example: If someone tries 9.2.3 should not match.
And also if someone tries 9.3.0 should also not match. So I would like to include 9.2.4 but not 9.3.0

Is not this the correct approach?

^ matches all the versions in the same major over the indicated version. ^9.2.4 is equal to ">= 9.2.4 AND < 10.0.0", so ^9.2.4 || ^9.3.1 || ^9.4.0 includes 9.3.0.

You need to use ~ to match only versions of the same minor, so ~9.2.4 || ~9.3.1 || ^9.4.0.

Thank you ! done in fix versions

@gizas : I still think this should not be done. As doing this we are actually removing any future support to versions like 8.19, 9.0, 9.1, 9.2 (lesser than 9.2.4), 9.3.0.
Can we instead update about this agent version dependency in the readme.

for core integrations like prometheus we really want to retain support for 8.x customers.

The reason for that was that the beats fix elastic/beats#48218 was not imported to 8.19 versions.

See above PR for relevant backports.
This relates to previous comment from Ishleen.

If you agree I can do:

^8.16.0 || ^9.2.4 || ^9.3.1 || ^9.4.0

and just document the limitations in README?

^8.16.0 || ^9.2.4 || ^9.3.1 || ^9.4.0 is equivalent to ^8.16.0 || ^9.2.4, so the package will be available in 9.3.0.

You probably want ^8.16.0 || ~9.2.4 || ^9.3.1.

Thank you @jsoriano ! @tommyers-elastic , @ishleenk17 do u agree to proceed with above versions and also document the fact that the existing variables will not work in 8.x ?

@tommyers-elastic , @ishleenk17 I did the backport to 8.19. See elastic/beats#48918

So now "^8.19.3 || ~9.2.5 || ^9.3.1" is the final one.
Can I have another review please?

Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>

github-actions · 2026-02-18T10:24:21Z

✅ Vale Linting Results

No issues found on modified lines!

The Vale linter checks documentation changes against the Elastic Docs style guide.

To use Vale locally or report issues, refer to Elastic style guide for Vale.

Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>

…ns into prometheus_body_bytes

elasticmachine · 2026-02-18T10:53:04Z

💚 Build Succeeded

Buildkite Build
Commit: b0d6774

History

💚 Build #37192 succeeded a40fe07
💚 Build #36899 succeeded 180fb75
💚 Build #36894 succeeded ce915d6
💚 Build #36436 succeeded 6faf09b

botelastic · 2026-03-20T11:15:22Z

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

botelastic · 2026-04-19T11:17:26Z

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

update request size limits

2418429

Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>

gizas requested review from a team as code owners January 14, 2026 14:32

gizas commented Jan 14, 2026

View reviewed changes

update changelog

6faf09b

Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>

andrewkroh added Integration:prometheus Prometheus documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] labels Jan 14, 2026

Merge branch 'main' into prometheus_body_bytes

ce915d6

MichaelKatsoulis reviewed Jan 26, 2026

View reviewed changes

Comment thread packages/prometheus/data_stream/remote_write/manifest.yml Outdated

gizas added 2 commits January 26, 2026 12:40

change value to integer

5fa0edd

Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>

Merge branch 'prometheus_body_bytes' of github.com:elastic/integratio…

180fb75

…ns into prometheus_body_bytes

jsoriano reviewed Jan 28, 2026

View reviewed changes

gizas added 3 commits January 30, 2026 11:32

fix versions

87d9441

Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>

Merge branch 'main' into prometheus_body_bytes

a40fe07

update changelog

7270dc6

Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>

gizas added 3 commits February 18, 2026 12:26

Merge branch 'main' into prometheus_body_bytes

977e90e

update doc

dd4ccac

Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>

Merge branch 'prometheus_body_bytes' of github.com:elastic/integratio…

b0d6774

…ns into prometheus_body_bytes

botelastic bot added the Stalled label Mar 20, 2026

github-actions bot mentioned this pull request Apr 16, 2026

[Elasticsearch]: Authentication fails when password contains YAML special characters (e.g. double quotes) #18434

Open

botelastic bot closed this Apr 19, 2026

Conversation

gizas commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed commit message

Checklist

How to test this PR locally

Related issues

Screenshots

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gizas commented Jan 26, 2026

Uh oh!

Uh oh!

gizas commented Jan 28, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gizas Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ishleenk17 Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gizas Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Vale Linting Results

Uh oh!

elasticmachine commented Feb 18, 2026

💚 Build Succeeded

History

Uh oh!

botelastic bot commented Mar 20, 2026

Uh oh!

botelastic bot commented Apr 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gizas commented Jan 14, 2026 •

edited

Loading

gizas Jan 29, 2026 •

edited

Loading

ishleenk17 Jan 30, 2026 •

edited

Loading

gizas Feb 4, 2026 •

edited

Loading

github-actions bot commented Feb 18, 2026 •

edited

Loading