Rebuild only when union find changes

[oflatt]

No description provided.

[Copilot]

Copilot wasn't able to review any files in this pull request.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

Merging this PR will improve performance by 17.33%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 10 improved benchmarks
✅ 28 untouched benchmarks
🆕 2 new benchmarks
⏩ 190 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
🆕	WallTime	tests[luminal-llama]	N/A	586.9 ms	N/A
⚡	WallTime	tests[extract-vec-bench]	78.6 ms	71.8 ms	+9.4%
⚡	WallTime	tests[typeinfer]	275.1 ms	253.2 ms	+8.66%
⚡	WallTime	tests[proof_testing_typecheck]	275.4 ms	238.5 ms	+15.49%
⚡	WallTime	tests[python_array_optimize]	6.9 s	6.5 s	+7.05%
⚡	Simulation	tests[typeinfer]	239.2 ms	219.9 ms	+8.78%
🆕	Simulation	tests[luminal-llama]	N/A	532.7 ms	N/A
⚡	Simulation	rust_rule_insert_loop[ops1000_funcs200]	622.2 µs	559.2 µs	+11.27%
⚡	Simulation	tests[proof_testing_unify]	21.4 ms	20.4 ms	+5.04%
⚡	Simulation	tests[proof_testing_typecheck]	256.3 ms	218.5 ms	+17.33%
⚡	Simulation	tests[proof_testing_eqsat-basic]	37.1 ms	34 ms	+9.08%
⚡	Simulation	tests[extract-vec-bench]	78.4 ms	72 ms	+8.89%

---

_{Comparing oflatt-rebuild-on-read (f272189) with main (21b99b6)}

Footnotes

1. 190 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.25%. Comparing base (21b99b6) to head (f272189).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
- Coverage   86.26%   86.25%   -0.01%     
==========================================
  Files          85       85              
  Lines       23262    23271       +9     
==========================================
+ Hits        20067    20073       +6     
- Misses       3195     3198       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[saulshanabrook]

The included benchmark from luminal improves that script by 17% with this change. It also runs a bunch of rules, so seems significant that just improving let binding performance by referring rebuilding has such a big impact!

[oflatt]

I don't think that screen shot above reflects the actual speedup- if you look at the diff it goes from 1.6 seconds to 0.3

That was for a different proof benchmark!