Add f64 exp, log, and sqrt primitives#834
Add f64 exp, log, and sqrt primitives#834saulshanabrook wants to merge 4 commits intoegraphs-good:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds new floating-point math primitives (exp, log, sqrt) to the existing f64 sort so they can be used directly in egglog programs, and extends the f64 egg tests to cover both valid and invalid-domain evaluations.
Changes:
- Register
exp,log, andsqrtasf64literal primitives (with domain checks forlogandsqrt). - Extend
tests/f64.eggwith passing checks for the new ops andfailcases for invalid inputs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/sort/f64.rs |
Registers exp, log, sqrt primitives for the f64 sort and updates the sort’s primitive list documentation. |
tests/f64.egg |
Adds egg tests validating correct results and expected failures for invalid domains. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merging this PR will not alter performance
Comparing Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #834 +/- ##
=======================================
Coverage 82.14% 82.15%
=======================================
Files 88 88
Lines 24867 24874 +7
=======================================
+ Hits 20428 20434 +6
- Misses 4439 4440 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
exp,log, andsqrtas f64 primitives