Fix webui version response when no patchlevel present - #1937
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5fe6e52e84
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #ifdef EGG_PATCH | ||
| stealth_telnets ? "nginx/1.28.0" : "Eggdrop/" EGG_STRINGVER "+" EGG_PATCH); | ||
| #else | ||
| stealth_telnets ? "nginx/1.28.0" : "Eggdrop/" EGG_STRINGVER); |
There was a problem hiding this comment.
When stealth_telnets is enabled, both conditional branches now emit nginx/1.28.0, silently reverting the deliberate 1.28.0 → 1.28.1 update from commit 7d160319 for every 404 and file response. The EGG_PATCH guard only needs to vary the Eggdrop banner; retain nginx/1.28.1 in both arms so this stable-build fix does not also change the externally visible stealth fingerprint.
Useful? React with 👍 / 👎.
2 participants
Found by: Geo
Patch by: Geo
One-line summary:
Fix version when no patchlevel present
Additional description (if needed):
webui was built against the develop branch which has a patch level defined. On stable, it is not defined and causes an undefined compilation error in the ternary logic.
Note for the future: for 1.10.3, recommend centralizing the definition of this variable and (unrelated) removing the nginx response from stealth_telnet.
Test cases demonstrating functionality (if applicable):